RubySec

Providing security resources for the Ruby community

GHSA-q66h-m87m-j2q6 (bitcoinrb): Bitcoinrb Vulnerable to Command injection via RPC

ADVISORIES

GEM

bitcoinrb

PATCHED VERSIONS

  • >= 1.12.0

DESCRIPTION

Summary: Remote Code Execution

Unsafe handling of request parameters in the RPC HTTP server results in command injection.

Details

In lib/bitcoin/rpc/http_server.rb line 30-39, the JSON body of a POST request is parsed into command and args variables. These values are then passed to send, which is used to call an arbitrary class method. However, there is no validation that the provided command value is one of the expected RPC methods. This means that an attacker could supply a command value such as system, and then pass arbitrary system commands into the args parameter and achieve remote code execution.

Remediation

Mitigating Factors:

  • The RPC server is part of the experimental SPV node feature, which is not documented and has very few users.
  • The SPV-related features may be removed in future releases.

Resolution:

  • Added whitelist validation to allow only RPC methods defined in RequestHandler.

  • Fixed in version 1.12.0.

RELATED